Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor pipeline---put runtime schedule into engine. #627

Merged
merged 5 commits into from
Apr 3, 2022

Conversation

YuliangLiu0306
Copy link
Contributor

  1. Build runtime schedule during initializing.
  2. Put runtime schedule as an attribute of engine.
  3. Because schedule is NOT an attribute of trainer, this commit refactor the trainer module accordingly.

@YuliangLiu0306 YuliangLiu0306 marked this pull request as draft April 1, 2022 10:36
@YuliangLiu0306 YuliangLiu0306 marked this pull request as ready for review April 1, 2022 10:37
@YuliangLiu0306 YuliangLiu0306 marked this pull request as draft April 1, 2022 10:45
@YuliangLiu0306 YuliangLiu0306 marked this pull request as ready for review April 1, 2022 10:51
colossalai/engine/_base_engine.py Outdated Show resolved Hide resolved
"""To perform actions before running the schedule.
"""
pass

@abstractmethod
def forward_backward_step(self,
engine: Engine,
engine,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type hint for engine

@feifeibear feifeibear merged commit ade05a5 into hpcaitech:main Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants