Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[profiler] add MemProfiler #356

Merged
merged 19 commits into from
Mar 29, 2022
Merged

[profiler] add MemProfiler #356

merged 19 commits into from
Mar 29, 2022

Conversation

jiezhuzzz
Copy link

@jiezhuzzz jiezhuzzz commented Mar 9, 2022 •
edited
Loading

TODOs:

  • offline implementation
    • save to a specific file
    • show results in CLI
    • show on TensorBoard
  • realtime implementation
    • trainer hook
    • save data

@FrankLeeeee FrankLeeeee force-pushed the develop branch 3 times, most recently from 20f4020 to 1e4bf85 Compare March 11, 2022 09:39
feifeibear
feifeibear reviewed Mar 14, 2022
View reviewed changes
colossalai/engine/_base_engine.py Outdated
for h in self._ophook_list:
if type(h) == type(ophook):
# TODO: what error should be raised
raise NotImplementedError
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did the hook exist you let the program fail? why not just return and give a warning?

Copy link
Author

@jiezhuzzz jiezhuzzz Mar 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did the hook exist you let the program fail? why not just return and give a warning?

You are right. I will fix it after I finish the overall profiler interface test.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error has been altered to warning. You could review 9fe8018 for more info.

@FrankLeeeee FrankLeeeee changed the base branch from develop to main March 16, 2022 08:10
@jiezhuzzz jiezhuzzz marked this pull request as ready for review March 16, 2022 08:15
@jiezhuzzz
Copy link
Author

The display of TB is shown as follow, image

@ver217 ver217 merged commit 73d3661 into hpcaitech:main Mar 29, 2022
@jiezhuzzz jiezhuzzz deleted the feature/mem_tracer branch March 31, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feifeibear feifeibear feifeibear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiezhuzzz @feifeibear @ver217