[DEVTOOLS-91] Adding connection limiter #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding entries to .gitignore [DEVTOOLS-91] Merging from master Conflicts: .gitignore [DEVTOOLS-91] Adding connection limiter [DEVTOOLS-91] Removing log statements [DEVTOOLS-91] Removing some cruft [DEVTOOLS-91] Implementing review comments [DEVTOOLS-91] A couple more little things [DEVTOOLS-91] Updating README and config-example.json
|
This PR should address issue-115 |
|
Also #113. Thanks so much for fixing this, I skimmed the change and it looks good. Token bucket in a channel was exactly what I planned to do. I'm a little behind in integrating PR's but I hope to get caught up very soon. |
| @@ -199,7 +199,7 @@ func init() { | |||
| // NOTE: The keys in the searcher map will be normalized to lower case, but not such | |||
| // transformation will be done on the error map to make it easier to match those errors | |||
| // back to the original repo name. | |||
| func MakeAll(cfg *config.Config) (map[string]*Searcher, map[string]error, error) { | |||
| func MakeAll(cfg *config.Config, connectionLimiter) (map[string]*Searcher, map[string]error, error) { | |||
There was a problem hiding this comment.
Finally got around to merge this tonight, but I'm finding it doesn't build.
kellegous
added a commit
that referenced
this pull request
Apr 28, 2015
|
@mmerrell Can you take a look at #118 and make sure it still solves the problem you are having. I changed a couple of things:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding entries to .gitignore to aid in Mac development
[DEVTOOLS-91] Adding connection limiter
[DEVTOOLS-91] Updating README and config-example.json