Make sure to also run build:test
in the build
step
#686
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes sure that the
build:test
command is also run as part of thebuild
andrelease
step.This way developers (especially plugin developers) can import all Stimulus' classes and types even if they are not publicly exported. We are not guaranteeing that those exports are non-breaking, but at least this will allow developers to make use of those classes even if we are not explicitly exporting them.
Importing classes would look something like:
And types could be imported like:
Resolves #623 and #638