fix: resolve GraphQL collection tree and tab dissociation issues #4537
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve the issues with the GraphQL workspace, where requests from the collection tree and the ones open under tabs get dissociated following certain actions.
Closes HFE-546 #4500.
What's changed
saveGraphqlRequestAs
function exposed from the store premises, invoking the underlying dispatcher now returns the insertion index for the request being added.undefined
resulting in dissociation with the tab.OnAddRequest
method in theCollectionGraphql
component removingindex
(resolved asundefined
) from the incoming data and leveraging the request index instead.CollectionsGraphqlAddRequest
component.requestIndex
field existence as a follow up of feat: duplicate REST/GraphQL collections #4211.Notes to reviewers
Please ensure to verify actions except for moves and overwrites via the
Save as new request
from the spotlight with requests from the collection tree and that the association is kept with the tabs in which they're open:Save as
modal.