-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug]: GraphQL Requests not saved to DB #4500
Comments
Should be fixed as of 2024.10.2 |
Hi @rb090, while you add a request, could you check if clicking on the request from the collection tree for the second time opens a new tab with the association being kept (any further updates are recorded correctly)? You can find a pill next to the request in the tree when it's open in a tab indicating it's the active item. Observe the association wasn't kept when the tab was open with the request being created, but during the second attempt, it would be marked as an active entry. We were able to reproduce issues with requests from the GraphQL collection tree and the tab getting dissociated following certain actions that can lead to a flow where the updates to the original request are lost and a fix is up for the same. |
Hi @jamesgeorge007, I am sorry for the late reply. Thank you so much that you are looking into this issue. We really appreciate this a lot.
No it does not. Lets say I have a request "TestQuery". If "TestQuery" is open in a tab and I click again on the request item in the collection, that does not happen. If no query "TestQuery" is open in a tab, I click on it in the collection once I created it, tab is opened and the green dot appers. Updates on the request are saved until I do a reload in my browser 😔.
Good catch, you are right on this. |
In this case, was the request open in a tab following the create action with no active indicator next to the request from the collection tree? Could you send a screen recording of this flow here or via the existing communication channel with @AndrewBastin as you prefer with any sensitive contents redacted? Also, if possible, at this stage, could you send the contents against the keys |
@jamesgeorge007 what do you think in having a call where we can debug and have a look together? I have the feeling that might be easier. If you agree please share with me how you are available and I can setup us sth. |
I had a chat with @AndrewBastin. Since there is already a fix addressing the concern about requests not getting synced to the workspace arising from the collection tree and tab state dissociating, let's schedule a call after the release as required if there are further concerns :) |
Thanks a lot for getting back to me @jamesgeorge007 and for working on this fix with @AndrewBastin 🙌💗. So we wait for the next release |
A quick update regarding a change in the release plan. The |
@jamesgeorge007 oh wow that are awesome news, thank you so much for your update on this and for taking care of this issue 🙌🍾. Looking forward to it. I will test with the new release and let you know in this ticket how it goes. |
Hi, the above fix is now released in v2024.11.0. Please let us know if the issue persists. |
Hi @jamesgeorge007, Thank you so much for the update and the fix 🙌! I hope you don’t mind the delay in my response, I was out of the office. I had the chance to test your fix today. It seems that adding GraphQL requests initially works perfectly, and all requests are added correctly with their content. However, once a request is saved, it’s not possible to make changes to it. Modifications to existing GraphQL requests aren’t being applied. When I check the database, the changes aren’t reflected there either. Could you please also let me know how to share GraphQL requests with teammates? For example, GraphQL requests I created aren't visible to any of my colleagues. Do workspaces not support sharing GraphQL requests? |
No worries, thanks for getting back.
Could you post a screen recording of the flow?
So currently, GraphQL applies only to the personal workspace, ref. |
Thank you so much for getting back to me @jamesgeorge007 and for providing the clarifications! I really appreciate your prompt response 🙌.
I understand that GraphQL is currently limited to personal workspaces. But it would be incredibly helpful for our team if we could share these across our workspace. Is there any chance this feature could be introduced soon? Are there any plans? Additionally, I recorded a quick screencast to demonstrate an issue I encountered. In the video, I open an existing request, make some changes, and then open a new tab to re-open the modified request. However, as shown, the attributes I removed still appear. I hope the video provides clarity, but I'm happy to jump on a call if further discussion is needed 🙂. Screencast-Change-Request.mp4 |
There are no immediate plans but, we have it in the pipeline. You can keep an eye on the open issues :)
Thanks. We'll investigate further. |
Hi, we have a patch that went out with the v2024.12.0 release, which addresses issues with request syncing. Could you take a look when you get a chance? |
Thank you so much, @jamesgeorge007, for letting me know and for providing the patch! I tested the new version today, and everything looks great so far. I modified existing requests, deleted collections with requests, and created new collections with requests. Everything seems to be working perfectly from what I can see. Thank you again for addressing these issues. Wishing you and the entire team a happy and healthy New Year! 🎉🎆 |
Awesome, thanks for confirming; closing this issue. Happy New Year 🥳 |
Is there an existing issue for this?
Current behavior
When I create a new GraphQL request within a Hoppscotch GraphQL request collection, its content gets not saved properly to the connected database to
UserRequest.request
into the propertiesquery
andvariables
.I am running Hoppscotch Community Edition via Docker AIO container on version
v2024.9.3
. It is connected to a PSQL DB.Steps to reproduce
UserRequest
we see that the attributes inrequest
are not matching the request saved in the UI:Could it be that I need to change sth within my configuration? This is how
.env
is looking like:Environment
Production
Version
Self-hosted
The text was updated successfully, but these errors were encountered: