Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some tweaks for Subview #24976

Merged
merged 3 commits into from
Nov 17, 2022
Merged

some tweaks for Subview #24976

merged 3 commits into from
Nov 17, 2022

Conversation

Mariusthvdb
Copy link
Contributor

@Mariusthvdb Mariusthvdb commented Nov 17, 2022 •
edited
Loading

and take out the 'more info below' since there was no more info below. Add a basic subview example.

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@Mariusthvdb
some tweaks for Subview
b897373 
and take out the 'more info below' since there was no more info below. Add a basic subview example.
@home-assistant home-assistant bot added the current This PR goes into the current branch label Nov 17, 2022
frenck
frenck requested changes Nov 17, 2022
View reviewed changes
source/dashboards/views.markdown Outdated Show resolved Hide resolved
source/dashboards/views.markdown Outdated
Comment on lines 228 to 236
title: Energieprijzen
path: energieprijzen
subview: true
back_path: /ui-data/climate

cards:
- type: entities
entities:
- etc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

etc?

Copy link
Contributor Author

@Mariusthvdb Mariusthvdb Nov 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, well, I guess that would be obvious. you want me to take out that line 236, or, prefer an entity
like sensor.today_avg_price

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some example, that would help :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@frenck frenck added the in-progress This PR/Issue is currently being worked on label Nov 17, 2022
Mariusthvdb and others added 2 commits November 17, 2022 14:57
frenck
frenck approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Mariusthvdb 👍

@frenck frenck merged commit c98a59f into home-assistant:current Nov 17, 2022
@home-assistant home-assistant bot removed the in-progress This PR/Issue is currently being worked on label Nov 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2022
@Mariusthvdb Mariusthvdb deleted the patch-24 branch September 25, 2024 07:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees

@Mariusthvdb Mariusthvdb

Labels
current This PR goes into the current branch
Projects
Documentation PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mariusthvdb @frenck