Compact more info header #15448
Merged
Compact more info header #15448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piitaya
force-pushed
the
more-info-navigation
branch
4 times, most recently
from
e34d266 to
4484b86
Compare
piitaya
force-pushed
the
more-info-navigation
branch
from
9975044 to
24287f9
Compare
bramkragten
reviewed
Feb 20, 2023
bramkragten
previously approved these changes
Feb 20, 2023
piitaya
force-pushed
the
more-info-navigation
branch
from
25b80b7 to
b291f6d
Compare
bramkragten
approved these changes
Feb 20, 2023
|
@piitaya and all thank you for your work on this topic - amazing new dialog!! Will you please think/work on the usability when it comes to closing the dialog on mobile (iOS)? Something like a close button at the bottom or making it more a popup than a full-screen dialog could work? Thank you again and apologies for the intrusion. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Tabs has been replaced by icons and overflow menu :
Demo
CleanShot.2023-02-16.at.14.41.15.mp4
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: