Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we have supervisor.addon #13353

Merged
merged 1 commit into from
Aug 7, 2022
Merged

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Aug 7, 2022

Breaking change

Proposed change

We want to fetch data from /store if the addon is installed and from /addons if not.
To check that we need that supervisor.addon exist before that.

This PR makes sure that we update that data before we try to show the addon.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@zsarnett zsarnett merged commit f5d9a7d into dev Aug 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the Make-sure-we-have-supervisor.addon branch August 7, 2022 21:56
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refresh while looking at addon always says it is stopped
3 participants