Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump pyjvcprojector to 1.0.12 to fix blocking call #123473

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Bump pyjvcprojector to 1.0.12 to fix blocking call #123473

merged 1 commit into from
Aug 9, 2024

Conversation

SteveEasley
Copy link
Contributor

@SteveEasley SteveEasley commented Aug 9, 2024 •
edited
Loading

Proposed change

Fixes blocking call warning reported in #119979.

Change made in dependent library to prevent the downstream dns dependency from causing the warning.

https://github.com/SteveEasley/pyjvcprojector/releases/tag/v1.0.12
https://pypi.org/project/pyjvcprojector/#history

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes # 119979
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Aug 9, 2024

Hey there @msavazzi, mind taking a look at this pull request as it has been labeled with an integration (jvc_projector) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of jvc_projector can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign jvc_projector Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@SteveEasley SteveEasley changed the title Fixed blocking call in dependent library release v1.0.12 Fixed blocking call in dependent library Aug 9, 2024
@SteveEasley SteveEasley changed the title Fixed blocking call in dependent library Fix blocking call in dependent library Aug 9, 2024
@bdraco bdraco changed the title Fix blocking call in dependent library Bump pyjvcprojector to 1.0.12 to fix blocking call Aug 9, 2024
@bdraco
Copy link
Member

bdraco commented Aug 9, 2024

SteveEasley/pyjvcprojector@v1.0.11...v1.0.12

@bdraco
Copy link
Member

bdraco commented Aug 9, 2024 •
edited
Loading

SteveEasley/pyjvcprojector@v1.0.11...v1.0.12#diff-661f155af534c9070ca9107bf10a81f4da24969112797d2942761dc5a2476fb0R73

It looks like the new exception type being raised: aiodns.error.DNSError might be a breaking change since nothing here is looking for that

@frenck frenck added this to the 2024.8.1 milestone Aug 9, 2024
@SteveEasley
Copy link
Contributor Author

SteveEasley commented Aug 9, 2024 •
edited
Loading 

    try:
        res = await aiodns.DNSResolver().gethostbyname(host, socket.AF_INET)
        if len(res.addresses) < 1:
            raise aiodns.error.DNSError("Unexpected zero length addresses response")
    except aiodns.error.DNSError as err:
        raise JvcProjectorConnectError(f"Failed to resolve host {host}") from err

It should be caught be caught by the outer except, and re-thrown as JvcProjectorConnectError just as before I think. I tested this locally just now and that is the case.

@bdraco
Copy link
Member

bdraco commented Aug 9, 2024 

    try:
        res = await aiodns.DNSResolver().gethostbyname(host, socket.AF_INET)
        if len(res.addresses) < 1:
            raise aiodns.error.DNSError("Unexpected zero length addresses response")
    except aiodns.error.DNSError as err:
        raise JvcProjectorConnectError(f"Failed to resolve host {host}") from err

It should be caught be caught by the outer except, and re-thrown as JvcProjectorConnectError just as before I think. I tested this locally just now and that is the case.

Its a bit unexpected to raise another libraries' exception there but it should work as you describe. I would have raised JvcProjectorConnectError directly instead.

@bdraco bdraco merged commit 1ad1a2d into home-assistant:dev Aug 9, 2024
40 checks passed
@SteveEasley
Copy link
Contributor Author

Yeah that occurred to me when I was commenting on it, not sure why I didnt do that originally. Will go ahead and make the change in the lib, and deploy the next good reason to update the HA side.

Thanks for looking!

frenck pushed a commit that referenced this pull request Aug 10, 2024
@SteveEasley @frenck
Bump pyjvcprojector to 1.0.12 to fix blocking call (#123473)
44e58a8
@frenck frenck mentioned this pull request Aug 10, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked cla-signed dependency integration: jvc_projector Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2024.8.1
Development

Successfully merging this pull request may close these issues.
3 participants
@SteveEasley @bdraco @frenck