Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ttyd and libwebsockets deps for ssh addon #2324

Merged
merged 3 commits into from
Jan 6, 2022

Conversation

bval
Copy link
Contributor

@bval bval commented Dec 23, 2021

In Safari 15 and later, the web terminal for the ssh add-on no longer renders properly. This bumps the libwebsockets version and ttyd version to correct that. ttyd has not had a release since January of this year, so this pins the update to the same SHA in use for the community add-on, where this fix is ported from and known to work.

Original issue report from community
Original PR resolving above issue
Closes #2186

@homeassistant
Copy link

Hi @bval,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@pvizeli
Copy link
Member

pvizeli commented Dec 29, 2021

Changelog + bump version 0.1.0

ssh/build.yaml Outdated Show resolved Hide resolved
@bval
Copy link
Contributor Author

bval commented Jan 5, 2022

Changelog + bump version 0.1.0

@pvizeli 👍

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been running this combination in the community add-on for a while now; most issues around this are gone now.

@ludeeus ludeeus merged commit cbf54bf into home-assistant:master Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminal&SSH addon unreadble CLI in Safari
5 participants