Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenNeuro GraphQL API, fix bug when not passing any includes #38

Merged
merged 15 commits into from
May 16, 2021

Conversation

hoechenberger
Copy link
Owner

No description provided.

@hoechenberger hoechenberger requested a review from agramfort May 16, 2021 09:58
@hoechenberger
Copy link
Owner Author

@agramfort Care to try out this branch and see if it crashes for you? 😅☠️

CHANGES.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for MRG provided CIs are happy

thx @hoechenberger

openneuro/download.py Outdated Show resolved Hide resolved
@hoechenberger
Copy link
Owner Author

+1 for MRG provided CIs are happy

We don't have any CI's at the moment ☠️🙈

@agramfort
Copy link
Collaborator

can you add one real quick?

@hoechenberger
Copy link
Owner Author

can you add one real quick?

will do this afternoon, out for a walk & coffee now! :)

openneuro/download.py Outdated Show resolved Hide resolved
@hoechenberger
Copy link
Owner Author

@agramfort I've added a super simple test case

@hoechenberger hoechenberger merged commit 488d0cf into main May 16, 2021
@hoechenberger hoechenberger deleted the gql branch May 16, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants