Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Ignore black-ify commit, add pre-commit config, lint with ruff #101

Merged
merged 6 commits into from
Jul 1, 2023
Merged

ENH: Ignore black-ify commit, add pre-commit config, lint with ruff #101

merged 6 commits into from
Jul 1, 2023

Conversation

larsoner
Copy link
Collaborator

Closes #99

@larsoner larsoner enabled auto-merge (squash) June 30, 2023 14:42
@larsoner larsoner disabled auto-merge June 30, 2023 14:42
larsoner
larsoner commented Jun 30, 2023
View reviewed changes
.github/workflows/run-linter.yml
run: |
python -m pip install --upgrade pip
python -m pip install flake8
- name: Lint with flake8
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced this with ruff in the pre-commit hook

Copy link
Collaborator Author

@larsoner larsoner Jun 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and it found the bad import sys)

@hoechenberger hoechenberger changed the title ENH: Ignore, pre-config, CI ENH: Ignore black-ify commit, add pre-commit config, lint with ruff Jul 1, 2023
@hoechenberger hoechenberger merged commit 91ea469 into hoechenberger:main Jul 1, 2023
@hoechenberger
Copy link
Owner

Thanks @larsoner!

@larsoner larsoner deleted the black branch July 1, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoechenberger hoechenberger hoechenberger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Black formatting
2 participants
@larsoner @hoechenberger