-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update outdated Cloudflare provider & resource #51
Update outdated Cloudflare provider & resource #51
Conversation
Thanks for you PR. I'm wondering whether cloudflare_zone could be used to retrieve an existing zone and its id. Could you verify this? |
@pstadler of course! It's now updated. |
main.tf
Outdated
domain = "${var.domain}" | ||
zone_id = "${var.cloudflare_zone_id}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be deleted now, no longer used.
Please check my comment and also change |
dff78c4
to
371c710
Compare
@pstadler README was already updated :) but otherwise all is now fixed, re-tested & squashed. |
Great! Thanks a lot 🍻 |
I think this is at least partially wrong. |
@mweibel I can say that I ran it from scratch and it worked back then at least :) There's a possibility that I just realized and is that the PR was opened just one day after v2 was released (and there's no version enforcement for this provider) so there's a possibility that I was using v1 when I was working on it. If the problem is really related to v1->v2 transition it should then be easy to fix by following the guide. |
It works. I tested it. See https://www.terraform.io/docs/providers/cloudflare/index.html#argument-reference |
Ah right, this is a newly introduced (?) API Token. Sorry for the confusion. |
This makes Cloudflare provider to work again but now users need to provide the zone ID as specified in https://www.terraform.io/docs/providers/cloudflare/r/record.html. Docs updated accordingly.
Just tested it and works fine :)
Fix #50