Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [DP-2108][DP-2234][DP-2303] Update packages #199

Merged
merged 12 commits into from
May 15, 2023
Merged

feat: [DP-2108][DP-2234][DP-2303] Update packages #199

merged 12 commits into from
May 15, 2023

Conversation

vincentkoc
Copy link
Contributor

@vincentkoc vincentkoc commented Apr 10, 2023

Link to Github Issue


What changes are proposed in this PR?


  • Originally team was going to uplift packages
  • Changes were to remove keyspaces

How was this tested?


  • Unit test and will test in Airflow branch

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 8845 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5750 lines exceeds the maximum allowed for the inline comments feature.

@shub-v shub-v marked this pull request as ready for review May 10, 2023 23:36
@shub-v shub-v requested a review from a team as a code owner May 10, 2023 23:36
Copy link
Contributor Author

@vincentkoc vincentkoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5747 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented May 11, 2023

Code Climate has analyzed commit ee52ede and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Bug Risk 1
Style 2

Note: there is 1 critical issue.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 57.3% (7.6% change).

View more on Code Climate.

@vincentkoc vincentkoc changed the title feat: [DP-2108][DP-2234] Update packages feat: [DP-2108][DP-2234][DP-2302] Update packages May 15, 2023
@vincentkoc vincentkoc changed the title feat: [DP-2108][DP-2234][DP-2302] Update packages feat: [DP-2108][DP-2234][DP-2303] Update packages May 15, 2023
Copy link
Contributor

@vbmudalige vbmudalige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shub-v shub-v merged commit d1307ac into master May 15, 2023
@shub-v shub-v deleted the DP-2108 branch May 15, 2023 23:30
@hip-infra
Copy link
Collaborator

🎉 This PR is included in version 1.68.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants