Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Migrate from attr.dataclass to dataclasses.dataclass #207

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

samithdisal
Copy link
Contributor

Link to Github Issue


What changes are proposed in this PR?


How was this tested?


@samithdisal samithdisal requested a review from a team as a code owner September 21, 2023 23:51
@@ -5,7 +5,7 @@

import numpy as np
import pandas as pd
from attr import dataclass
from dataclasses import dataclass
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

standard import from dataclasses import dataclass should be placed before import numpy as np

@codeclimate
Copy link

codeclimate bot commented Sep 21, 2023

Code Climate has analyzed commit 83bd9fe and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 57.3% (0.0% change).

View more on Code Climate.

@samithdisal samithdisal merged commit fc02536 into master Sep 21, 2023
@samithdisal samithdisal deleted the fix-attr_to_dataclasses branch September 21, 2023 23:55
@hip-infra
Copy link
Collaborator

🎉 This PR is included in version 1.68.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants