feat: update cassandra connection settings signature #180
Conversation
hip_data_tools/apache/cassandra.py
Outdated
| @@ -160,6 +160,7 @@ class CassandraConnectionSettings: | |||
| load_balancing_policy: LoadBalancingPolicy | |||
| secrets_manager: CassandraSecretsManager | |||
| ssl_options: dict = None | |||
| consistency_level: Optional[ConsistencyLevel] = ConsistencyLevel.LOCAL_ONE | |||
There was a problem hiding this comment.
| consistency_level: Optional[ConsistencyLevel] = ConsistencyLevel.LOCAL_ONE |
This may not work with legacy mode
There was a problem hiding this comment.
If we are assigning a default value to it, it doesn't need to be an Optional right?
There was a problem hiding this comment.
@Rukesh-Kapuluru what is "legacy mode"? you mean python?
There was a problem hiding this comment.
Cassandra connection currently in use old type.Recent option is to use execution profiles.
There was a problem hiding this comment.
If we are assigning a default value to it, it doesn't need to be an
Optionalright?
Good catch. Removed Optional from type hint.
|
Code Climate has analyzed commit 6c4b9b9 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 0.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 49.6% (0.0% change). View more on Code Climate. |
hip_data_tools/apache/cassandra.py
Outdated
| @@ -160,6 +160,7 @@ class CassandraConnectionSettings: | |||
| load_balancing_policy: LoadBalancingPolicy | |||
| secrets_manager: CassandraSecretsManager | |||
| ssl_options: dict = None | |||
| consistency_level: Optional[ConsistencyLevel] = ConsistencyLevel.LOCAL_ONE | |||
There was a problem hiding this comment.
Cassandra connection currently in use old type.Recent option is to use execution profiles.
What changes are proposed in this PR?
How was this tested?