Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sets the consistency level #177

Merged
merged 4 commits into from
Jun 9, 2022
Merged

feat: sets the consistency level #177

merged 4 commits into from
Jun 9, 2022

Conversation

shubhank-v
Copy link
Contributor

@shubhank-v shubhank-v commented Jun 9, 2022

What changes are proposed in this PR?


  • This PR sets the consistency level to LOCAL_QUORUM in CassandraConnectionManager.

How was this tested?


  • Will test in Airflow

@shubhank-v shubhank-v requested a review from a team as a code owner June 9, 2022 02:20
@@ -18,6 +18,7 @@
"most_specific_location"]

LOG = logging.getLogger(__name__)
LOG.setLevel(logging.DEBUG)
Copy link

@tusharm tusharm Jun 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we hook this to a flag or an env var? just to avoid all consumers to start flooding cloudwatch..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toggling via env varirable

Copy link
Contributor

@vincentkoc vincentkoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment from @tusharm

@Rukesh-Kapuluru Rukesh-Kapuluru changed the title feat: set log level to debug feat: sets the consistency level Jun 9, 2022
@Rukesh-Kapuluru Rukesh-Kapuluru self-requested a review June 9, 2022 05:04
@codeclimate
Copy link

codeclimate bot commented Jun 9, 2022

Code Climate has analyzed commit 43dd91b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.6% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@vincentkoc vincentkoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rukesh-Kapuluru Rukesh-Kapuluru merged commit 74f074c into master Jun 9, 2022
@Rukesh-Kapuluru Rukesh-Kapuluru deleted the keyspaces-debug branch June 9, 2022 06:56
@hip-ci
Copy link

hip-ci commented Jun 9, 2022

🎉 This PR is included in version 1.65.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants