Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: testing new workflow private Update build-deploy.yml #33

Merged
merged 22 commits into from
Nov 30, 2023
Merged

chore: testing new workflow private Update build-deploy.yml #33

merged 22 commits into from
Nov 30, 2023

Conversation

caaops-hip
Copy link
Contributor

@caaops-hip caaops-hip commented Nov 29, 2023 •
edited by viniciusps
Loading

Testing new workflow private Update build-deploy.yml

Summary

1 line explicite Summary equivalent to the PR title

Type

Check one that is relevant

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature and improvements (non-breaking change which adds/improves functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Code Refactoring (internal change which is not user facing)
  • Documentation
  • Test, CI, or build

Description

A longer description of all changes in this pull request.

Jira Link

Link to relevant Jira tickets, stories, epic

Checklist before submitting:

  • Have you followed the general guidelines of GitFlow or GitHub Flow?
  • Have you verified no Secrets/Credentials present in commit ?
  • Have you updated test cases relevants for your code changes?
  • Have you verified all test are passing?
  • Have you verified you code is compliant with best practices?

@caaops-hip
chore: testing new workflow private Update build-deploy.yml
97101b5 
Testing new workflow private Update build-deploy.yml
github-actions[bot]
github-actions bot reviewed Nov 29, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid JIRA ticket title is required ie. [ABC-123]

caaops-hip and others added 8 commits November 29, 2023 16:49
@caaops-hip
chore: testing new coverage Update build-deploy.yml
096264e 
Testing new coverage Update build-deploy.yml
@caaops-hip
chore: testing Update additional checks
57b1d92 
 testing Update additional checks
@caaops-hip
chore: Update additional_checks.yaml
ccc5b35 
Update additional_checks.yaml
@caaops-hip
chore: Update build-deploy.yml
daedbfc 
Update build-deploy.yml
@caaops-hip
chore: Update build-deploy.yml
72a40e9 
yaml lint fix Update build-deploy.yml
@caaops-hip
chore: Update build-deploy.yml
898a230 
fix yaml lint
pre-commit linting
c6fd2fd
@caaops-hip
chore: Update build-deploy.yml
473a1ec
@shumingpeh
Copy link
Contributor

@cauesantos-hipages you might want to run pre-commit run -a on your local machine to fix the linting issues.

i just ran it, and pushed the linting fix

@caaops-hip
Copy link
Contributor Author

Update build-deploy yaml file to get token from private Hipages repo.

@caaops-hip caaops-hip merged commit 9f91002 into master Nov 30, 2023
10 of 11 checks passed
@caaops-hip caaops-hip deleted the cauesantos-hipages-patch-1 branch November 30, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@wattychops wattychops Awaiting requested review from wattychops

@mithunra mithunra Awaiting requested review from mithunra

@stimsoni9 stimsoni9 Awaiting requested review from stimsoni9 stimsoni9 is a code owner

@shumingpeh shumingpeh Awaiting requested review from shumingpeh shumingpeh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caaops-hip @shumingpeh @viniciusps