Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom cartpole #813

Merged
merged 4 commits into from
Apr 19, 2020
Merged

Conversation

aakash94
Copy link

@aakash94 aakash94 commented Apr 19, 2020

Description

Delete the file stable_baselines\deepq\experiments\custom_cartpole.py
Delete calls made to the above deleted file intests\test_deepq.py
No other references to the deleted file were found.

Motivation and Context

This change is in direct response to problems seen in running custom_cartpole.py
As discussed in the comments of the both the issues discussing it, the file is being removed, along with any references made to it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have ensured pytest and pytype both pass (by running make pytest and make type).
    pytest and pytype not verified because running those, causes my laptop to throttle and hang. Since the changes are not part of functional code, I think it will be fine.

aakash94 and others added 4 commits April 19, 2020 01:48
- Remove calls to custom cartpole
- hill-a#810
- hill-a#812
- move changes from deprecations to documentations
Copy link
Collaborator

@araffin araffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks =)

@araffin araffin merged commit d699d6f into hill-a:master Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error running custom_cartpole.py Deepq train custom cartpole doesn't work
2 participants