Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for other keytypes to openssh-key-v1 keyfiles #485

Merged
merged 4 commits into from
Jan 17, 2019
Merged

Add support for other keytypes to openssh-key-v1 keyfiles #485

merged 4 commits into from
Jan 17, 2019

Conversation

hierynomus
Copy link
Owner

@hierynomus hierynomus commented Jan 16, 2019 •
edited
Loading

This will fix #276 and fix #484

@codecov-io
Copy link

codecov-io commented Jan 16, 2019 •
edited
Loading

Codecov Report

Merging #485 into master will increase coverage by 0.05%.
The diff coverage is 78.94%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #485      +/-   ##
============================================
+ Coverage     55.92%   55.98%   +0.05%     
- Complexity     1220     1224       +4     
============================================
  Files           192      192              
  Lines          7871     7897      +26     
  Branches        715      717       +2     
============================================
+ Hits           4402     4421      +19     
- Misses         3121     3125       +4     
- Partials        348      351       +3
Impacted Files Coverage Δ Complexity Δ
...izz/sshj/userauth/keyprovider/KeyProviderUtil.java 57.69% <0%> (ø) 10 <0> (-1) ⬇️
...sshj/userauth/keyprovider/OpenSSHKeyV1KeyFile.java 76.06% <81.08%> (-0.86%) 18 <1> (+3)
...net/schmizz/sshj/transport/TransportException.java 44.44% <0%> (-11.12%) 4% <0%> (ø)
...ain/java/net/schmizz/sshj/common/SSHException.java 67.74% <0%> (-6.46%) 13% <0%> (ø)
...zz/sshj/connection/channel/ChannelInputStream.java 76.11% <0%> (+2.98%) 16% <0%> (+1%) ⬆️
...t/schmizz/sshj/connection/ConnectionException.java 44.44% <0%> (+11.11%) 4% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00cd335...3d7242d. Read the comment docs.

@hierynomus
Copy link
Owner Author

Also fixes #484

@hierynomus hierynomus merged commit cac340d into master Jan 17, 2019
@hierynomus hierynomus deleted the issue-276 branch January 17, 2019 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hierynomus @codecov-io