Add permalink metadata to message object #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volker-fr
force-pushed
the
add-permalink
branch
2 times, most recently
from
7dc9b2e to
b134458
Compare
volker-fr
force-pushed
the
add-permalink
branch
from
b134458 to
155d4c1
Compare
|
@hfaran This PR should now also be ready. When using templates, the new option can be used. This way the current default output doesn't need to be modified. |
volker-fr
commented
Jan 1, 2025
| @@ -19,7 +19,7 @@ class SlackFormatter(object): | |||
| # Class-level constants for precompilation of frequently-reused regular expressions | |||
| # URL detection relies on http://stackoverflow.com/a/1547940/1798683 | |||
| _LINK_PAT = re.compile(r"<(https|http|mailto):[A-Za-z0-9_\.\-\/\?\,\=\#\:\@]+\|[^>]+>") | |||
| _MENTION_PAT = re.compile(r"<((?:#C|@[UB])\w+)(?:\|([A-Za-z0-9.-_]+))?>") | |||
There was a problem hiding this comment.
This is a bugfix for slackdump. Slackdump channels are "<#C....|> without any character after the pipe.
If nothing is behind the pipe symbol, the existing logic will fall back looking up the proper channel name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add permalink option to message object. It's not used in this PR since I do not want to commit a modified template.
While its currently not used by
templates/util.html, it can be used when providing your own template. Example has been added to the existing template.