-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add truncated exponential backoff with full jitter #459
Conversation
I provided a |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #459 +/- ##
==========================================
+ Coverage 71.40% 71.49% +0.08%
==========================================
Files 45 45
Lines 3864 3876 +12
==========================================
+ Hits 2759 2771 +12
Misses 691 691
Partials 414 414 ☔ View full report in Codecov by Sentry. |
94df1aa
to
39ba358
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general. Could you describe where the 24 seconds are coming from?
39ba358
to
72bc103
Compare
72bc103
to
62f2c0f
Compare
62f2c0f
to
ae4bf37
Compare
ae4bf37
to
5df651a
Compare
This PR now primarily adds a new back off function. The change to the existing The change to the default values of the existing |
🤖 I have created a release *beep* *boop* --- ## [2.11.0](v2.10.2...v2.11.0) (2024-07-23) ### Features * add truncated exponential backoff with full jitter ([#459](#459)) ([fd1f46c](fd1f46c)) * allow configuring retry options ([#488](#488)) ([2db9575](2db9575)) * **exp:** add sliceutil package ([#489](#489)) ([f4ad6bc](f4ad6bc)) * **exp:** rename `*utils` package to `*util` ([#487](#487)) ([19da475](19da475)) * respect cancelled contexts during retry sleep ([#470](#470)) ([756f605](756f605)) * retry requests when the api gateway errors ([#470](#470)) ([756f605](756f605)) * retry requests when the network timed out ([#470](#470)) ([756f605](756f605)) * retry requests when the rate limit was reached ([#470](#470)) ([756f605](756f605)) ### Bug Fixes * **exp:** set capacity for each batch ([#490](#490)) ([57f53c1](57f53c1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…1.0 (hetznercloud/fleeting-plugin-hetzner!98) This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/hetznercloud/hcloud-go/v2](https://github.com/hetznercloud/hcloud-go) | require | minor | `v2.10.2` -> `v2.11.0` | --- ### Release Notes <details> <summary>hetznercloud/hcloud-go (github.com/hetznercloud/hcloud-go/v2)</summary> ### [`v2.11.0`](https://github.com/hetznercloud/hcloud-go/releases/tag/v2.11.0) [Compare Source](hetznercloud/hcloud-go@v2.10.2...v2.11.0) ##### Features - add truncated exponential backoff with full jitter ([#​459](hetznercloud/hcloud-go#459)) ([fd1f46c](hetznercloud/hcloud-go@fd1f46c)) - allow configuring retry options ([#​488](hetznercloud/hcloud-go#488)) ([2db9575](hetznercloud/hcloud-go@2db9575)) - **exp:** add sliceutil package ([#​489](hetznercloud/hcloud-go#489)) ([f4ad6bc](hetznercloud/hcloud-go@f4ad6bc)) - **exp:** rename `*utils` package to `*util` ([#​487](hetznercloud/hcloud-go#487)) ([19da475](hetznercloud/hcloud-go@19da475)) - respect cancelled contexts during retry sleep ([#​470](hetznercloud/hcloud-go#470)) ([756f605](hetznercloud/hcloud-go@756f605)) - retry requests when the api gateway errors ([#​470](hetznercloud/hcloud-go#470)) ([756f605](hetznercloud/hcloud-go@756f605)) - retry requests when the network timed out ([#​470](hetznercloud/hcloud-go#470)) ([756f605](hetznercloud/hcloud-go@756f605)) - retry requests when the rate limit was reached ([#​470](hetznercloud/hcloud-go#470)) ([756f605](hetznercloud/hcloud-go@756f605)) ##### Bug Fixes - **exp:** set capacity for each batch ([#​490](hetznercloud/hcloud-go#490)) ([57f53c1](hetznercloud/hcloud-go@57f53c1)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
https://aws.amazon.com/blogs/architecture/exponential-backoff-and-jitter/
BEGIN_COMMIT_OVERRIDE
feat: add truncated exponential backoff with full jitter (#459)
END_COMMIT_OVERRIDE