Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cain identify sometimes fails and falls back to using tome #600

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

srliao
Copy link
Contributor

@srliao srliao commented Dec 22, 2024

Sometimes even after Cain identifies all items, the bot will try to use tome to id the same items again. This is caused by sometimes there being a small delay where the server will say something like "waiting for action to complete".

The current code assumes that identification is completed immediately and as such returns error during this small delay, which causes it to fallback to the default identify with tome.

This pr adds a small delay after interacting with Cain to give it time to complete

@artosimonyan artosimonyan merged commit 4ecbb0e into hectorgimenez:main Dec 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants