-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable CainIdentify with CharacterCfg option #569
enable CainIdentify with CharacterCfg option #569
Conversation
e6c2c66
to
99e8988
Compare
Hehe, forgot to enable this as I didn't test it extensively after adding it. Glad to hear it's working as expected. Few notes though:
|
Thanks for the comments. I'll get the first two points fixed. Regarding the fallback logic, we'll need this PR merged first unfortunately: hectorgimenez/d2go#54 as currently the quest data is not present. In addition, the
|
1a13664
to
09ac51a
Compare
Revert this: 09ac51a. We don't need anything from d2go. If it doesn't find Cain in town, the Identify with Cain will return an error, in which case we can proceed and use old logic. Don't try to overly complicate stuff. |
Done |
I assume that should be a separate PR since it's an unrelated change to Cain? I can make the change on this PR if the maintainer wants me to though |
Added option to enable the existing
CainIdentify
code from here. Tested on SP and it seems to work pretty well.