Attempt to fix crash that occurs mostly on people running Koolo with mods. #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update foxMaxAttacksLoop to 20, some FoH characters don't deal enough damage and it takes more than 10 hits in order to kill bosses with high LR such as Mephisto, Diablo, Baal.
Added additional checks in order to attempt and fix `error="runtime error: index out of range [2500] with length 760"` & fixed typos in some comment for better readability. Users testing the changes had over 500 successful runs without crashing, additional modifications may be required until it's perfectly polished to prevent crashes with mods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional checks in order to attempt and fix
error="runtime error: index out of range [2500] with length 760"as well as fixed typos in some comments for better readability.Users testing the changes had over
500 successful runswithout crashing, additional modifications may be required until it's perfectly polished to prevent crashes with mods.