Add foldCopyData helper function #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phadej
requested changes
Nov 24, 2020
There was a problem hiding this comment.
The withCopyData and getAllCopyData are too specific functions.
I'd rather write something like
-- | Fold over @COPY TO STDOUT@ query. ... same notes as for 'getCopyData'.
foldCopyData
:: (a -> ByteString -> IO a) -- ^ Accumulate one row of the result
-> (a -> Int64 -> IO b) -- ^ Post-process accumulator with a count of rows
-> a -- ^ Initial accumulator
-> IO b -- ^ Resultand let people specialise.
Your getAllCopyData has performance issue, ++ is quadratic when used like that.
Check difference lists (i.e. composing [a] -> [a] functions).
It would be a simple instantiation of foldCopyData
|
@phadej thank you for the feedback! I completely agree with you, I think both functions could be replaced by a more general function. I'll work on it. |
sestrella
changed the title
|
Good, thanks! |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new function called foldCopyData which folds over
COPY TO STDOUTquery.