Add annotation to change init container order #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malnick
reviewed
Mar 2, 2020
malnick
reviewed
Mar 2, 2020
|
Since it was relevant I also fixed a bug where the init containers weren't getting secret mount volumes. Init containers can now consume Vault secrets if the Vault Agent runs first. |
tvoran
reviewed
Mar 2, 2020
tvoran
approved these changes
Mar 2, 2020
tvoran
added
enhancement
Merged
RemcoBuddelmeijer
pushed a commit
to RemcoBuddelmeijer/vault-k8s
that referenced
this pull request
Feb 22, 2022
* Add annotation to change init container order * Fix comment * Fix init containers not getting secret mounts * Resolve suggestions * Guard against misconfiguration of agent first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new annotation
vault.hashicorp.com/agent-init-firstwhich reorders the init container array to make the Vault Agent first. Since init containers run sequentially in order they're defined, this makes when the Vault Agent runs configurable depending on different use cases (such as init containers that need vault secrets).Also added secret mounts to other init containers present in the pod so they can consume Vault secrets if Vault Agent runs first.
Resolves #53 .