CI: test against n-2 versions of Vault #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhjp
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Thanks for taking this on. The same comments that I made in hashicorp/vault-csi-provider#249 also apply here, but again I am happy either way.
tomhjp
approved these changes
Mar 21, 2024
tvoran
reviewed
Mar 26, 2024
test/kind/config.yaml
Outdated
There was a problem hiding this comment.
Is this file being used? Looks like the tests are using the kind config from the vault-helm checkout?
There was a problem hiding this comment.
Nope, it was leftover from a previous attempt to make the tests more self contained. Unfortunately, running the tests locally requires pulling in vault-helm, and doing lots of manual setup.
Removed it.
benashz
force-pushed
the
VAULT-24903/test-n-2-vault-versions
branch
from
75c35f9 to
e663af2
Compare
|
@tvoran should be good for another pass. Thanks! |
tvoran
approved these changes
Mar 27, 2024
benashz
force-pushed
the
VAULT-24903/test-n-2-vault-versions
branch
from
7423376 to
c4b2432
Compare
benashz
force-pushed
the
VAULT-24903/test-n-2-vault-versions
branch
from
cb364e3 to
892d419
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for testing the VAI against n-2 versions of Vault. It is adapted from the work done in the vault-secrets-operator project.
Relates to hashicorp/vault-csi-provider#249