feat: add AGENT_INJECT_VAULT_AUTH_PATH option to the injector #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
+1 |
tvoran
requested changes
Feb 28, 2020
There was a problem hiding this comment.
Hi @rasta-rocket, thanks for adding this! See my comments about injector vs server. Could you also add some tests for this parameter in test/unit/injector-deployment.bats? There's also a small conflict to be resolved.
rasta-rocket
force-pushed
the
custom_auth_path
branch
from
cf19c64 to
f068b61
Compare
|
Updated 👍 |
tvoran
reviewed
Mar 3, 2020
* Add related unit tests
rasta-rocket
force-pushed
the
custom_auth_path
branch
from
f068b61 to
2816f6a
Compare
tvoran
approved these changes
Mar 3, 2020
|
Thanks! |
radudd
pushed a commit
to radudd/vault-helm
that referenced
this pull request
Jun 5, 2020
…orp#185) * Add related unit tests
hadielaham88
pushed a commit
to SolaceDev/vault-helm
that referenced
this pull request
May 19, 2021
…orp#185) * Add related unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.