Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set HOME=/home/vault in UBI Dockerfile #15439

Merged
merged 1 commit into from
May 16, 2022
Merged

Conversation

cipherboy
Copy link
Contributor

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>


Missed an important line from the UBI Dockerfile.

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
@cipherboy cipherboy added this to the 1.11.0-rc1 milestone May 16, 2022
@cipherboy cipherboy requested a review from tvoran May 16, 2022 15:20
@cipherboy cipherboy merged commit 48967c8 into main May 16, 2022
@cipherboy
Copy link
Contributor Author

Thanks!

@cipherboy cipherboy deleted the cipherboy-fix-ubi-set-HOME branch May 17, 2022 14:33
cipherboy added a commit that referenced this pull request May 31, 2022
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
cipherboy added a commit that referenced this pull request May 31, 2022
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
cipherboy added a commit that referenced this pull request May 31, 2022
* UBI Containerfile - CRT Enablement  (#15272)

* Copy UBI Dockerfile into Vault

This Dockerfile was modeled off of the existing Alpine Dockerfile (in
this repo) and the external Dockerfile from the docker-vault repo:

> https://github.com/hashicorp/docker-vault/blob/master/ubi/Dockerfile

We also import the UBI-specific docker-entrypoint.sh, as certain
RHEL/Alpine changes (like interpreter) require a separate entry script.

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>

* Add UBI build to CRT pipeline

Also adds workflow_dispatch to the CRT pipeline, to allow manually
triggering CRT from PRs, when desired.

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>

* Update Dockerfile

Co-authored-by: Sam Salisbury <samsalisbury@gmail.com>

* Update Dockerfile

Co-authored-by: Sam Salisbury <samsalisbury@gmail.com>

* Update Dockerfile

Co-authored-by: Sam Salisbury <samsalisbury@gmail.com>

* Update Dockerfile

* Update Dockerfile

* Update build.yml

Allow for both push to arbitrary branch plus workflow dispatch, per Newsletter article.

------

Also pulls in changes from 0ee2ac3 as
this wasn't backported.

------

Co-authored-by: Sam Salisbury <samsalisbury@gmail.com>

* Set HOME=/home/vault in UBI Dockerfile (#15439)

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>

* Fix ubi-docker-entrypoint.sh->docker-entrypoint.sh (#15443)

It is believed to break the helm chart; see also:

#15272 (comment)

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>

* Fix value of VAULT_DISABLE_FILE_PERMISSIONS_CHECK (#15438)

This variable doesn't use ParseBool and thus strictly requires "true" as
the value.

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>

* Update Dockerfile

Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>

Co-authored-by: Sam Salisbury <samsalisbury@gmail.com>
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
cipherboy added a commit that referenced this pull request May 31, 2022
* UBI Containerfile - CRT Enablement  (#15272)

* Copy UBI Dockerfile into Vault

This Dockerfile was modeled off of the existing Alpine Dockerfile (in
this repo) and the external Dockerfile from the docker-vault repo:

> https://github.com/hashicorp/docker-vault/blob/master/ubi/Dockerfile

We also import the UBI-specific docker-entrypoint.sh, as certain
RHEL/Alpine changes (like interpreter) require a separate entry script.

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>

* Add UBI build to CRT pipeline

Also adds workflow_dispatch to the CRT pipeline, to allow manually
triggering CRT from PRs, when desired.

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>

* Update Dockerfile

Co-authored-by: Sam Salisbury <samsalisbury@gmail.com>

* Update Dockerfile

Co-authored-by: Sam Salisbury <samsalisbury@gmail.com>

* Update Dockerfile

Co-authored-by: Sam Salisbury <samsalisbury@gmail.com>

* Update Dockerfile

* Update Dockerfile

* Update build.yml

Allow for both push to arbitrary branch plus workflow dispatch, per Newsletter article.

------

Also pulls in changes from 0ee2ac3 as
this wasn't backported.

------

Co-authored-by: Sam Salisbury <samsalisbury@gmail.com>

* Set HOME=/home/vault in UBI Dockerfile (#15439)

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>

* Fix ubi-docker-entrypoint.sh->docker-entrypoint.sh (#15443)

It is believed to break the helm chart; see also:

#15272 (comment)

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>

* Fix value of VAULT_DISABLE_FILE_PERMISSIONS_CHECK (#15438)

This variable doesn't use ParseBool and thus strictly requires "true" as
the value.

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>

* Update Dockerfile

Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>

Co-authored-by: Sam Salisbury <samsalisbury@gmail.com>
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants