Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding CRT to main branch #13088

Merged
merged 5 commits into from
Dec 6, 2021
Merged

adding CRT to main branch #13088

merged 5 commits into from
Dec 6, 2021

Conversation

claire-labry
Copy link
Collaborator

@claire-labry claire-labry commented Nov 8, 2021 •
edited
Loading

This is CRT being implemented for the main branch cc: @mdeggies

builds pass successfully: https://github.com/hashicorp/vault/actions/runs/1437011717

TODO (once this draft PR looks good/ready):

  • Change the slack channel ID to vault-releases
  • Change release_branches in ci.hcl to reflect this structure:
 github {
    organization = "hashicorp"
    repository = "vault"
    release_branches = [
      "main",
      "release/1.6.x",
      "release/1.7.x",
      "release/1.8.x",
      "release/1.9.x"
    ]
  }
  • Change to push to main in build.yml

@vercel vercel bot temporarily deployed to Preview – vault November 12, 2021 20:15 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook November 12, 2021 20:15 Inactive
@vercel vercel bot temporarily deployed to Preview – vault November 12, 2021 20:18 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook November 12, 2021 20:18 Inactive
@claire-labry claire-labry marked this pull request as ready for review November 12, 2021 20:35
@claire-labry claire-labry requested a review from mladlow November 12, 2021 20:35
@claire-labry claire-labry changed the title [DRAFT] adding CRT to main branch adding CRT to main branch Nov 12, 2021
@ncabatoff
Copy link
Collaborator

Is this missing vault.service?

@vercel vercel bot temporarily deployed to Preview – vault-storybook November 30, 2021 17:40 Inactive
@vercel vercel bot temporarily deployed to Preview – vault November 30, 2021 17:40 Inactive
@kpenfound
Copy link
Contributor

@ncabatoff added vault.service, good catch

@kpenfound kpenfound merged commit 1bec996 into main Dec 6, 2021
@kpenfound kpenfound deleted the crt_onboarding_main branch December 6, 2021 16:18
heppu pushed a commit to heppu/vault that referenced this pull request Jan 13, 2022
@claire-labry @kpenfound @heppu
adding CRT to main branch (hashicorp#13088)
f82f070 
* adding CRT to main branch

* cleanup

* um i dont know how that got removed but heres the fix

* add vault.service

Co-authored-by: Kyle Penfound <kpenfound11@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncabatoff ncabatoff ncabatoff approved these changes

@kpenfound kpenfound Awaiting requested review from kpenfound

@mladlow mladlow Awaiting requested review from mladlow

Assignees
No one assigned
Labels
pr/no-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@claire-labry @ncabatoff @kpenfound @mdeggies