Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pki_secret_backend_role to allow key_type "any" #791

Merged
merged 4 commits into from
Apr 27, 2022
Merged

Update pki_secret_backend_role to allow key_type "any" #791

merged 4 commits into from
Apr 27, 2022

Conversation

philband
Copy link
Contributor

@philband philband commented Jun 5, 2020

This PR updates the vault_pki_secret_backend_role to allow any as key_type. It permits issuing certificates with private keys other than ec or rsa from CSRs.

Relevant vault docs specifying this feature: https://www.vaultproject.io/api-docs/secret/pki#key_type-1

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

vault_pki_secret_backend_role: Allow key_type "any" for pki roles.

@ghost ghost added the size/XS label Jun 5, 2020
@taemon1337
Copy link
Contributor

I would like this to get approved

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@benashz benashz added this to the 3.6.0 milestone Apr 26, 2022
@benashz
Copy link
Contributor

benashz commented Apr 26, 2022

@taemon1337 thank you for the contribution. I wonder if you wouldn't mind also documenting the supported key_type's in website/docs/r/pki_secret_backend_role.html.md.

Thanks,

Ben

@taemon1337
Copy link
Contributor

@taemon1337 thank you for the contribution. I wonder if you wouldn't mind also documenting the supported key_type's in website/docs/r/pki_secret_backend_role.html.md.

Thanks,

Ben

I was able to submit a patch to @philband 's PR but I don't have access to that repo so he will have to commit.

You can see it here - taemon1337@83bae08

@benashz benashz self-requested a review April 26, 2022 21:47
@philband philband force-pushed the fix-pki-role-key-type branch from 85daaaf to 7b927c5 Compare April 27, 2022 09:53
@philband
Copy link
Contributor Author

@taemon1337 thank you for the patch. I added it into this pull request.
@benashz I have also rebased, so everything should me mergeable.

benashz
benashz approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank your for your contribution to HashiCorp!

@benashz
Copy link
Contributor

benashz commented Apr 27, 2022

Hi @taemon1337, would you mind please signing the CLA? After that we can merge this PR.

Thanks again @philband for your contribution.

@benashz benashz merged commit 95d5822 into hashicorp:main Apr 27, 2022
marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022
@philband @taemon1337 @benashz
Update pki_secret_backend_role to allow key_type "any" (hashicorp#791)
fb83e72 
Co-authored-by: taemon1337 <taemon1337@gmail.com>
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz approved these changes

Assignees
No one assigned
Labels
documentation size/XS
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@philband @taemon1337 @hashicorp-cla @benashz