Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db/cassandra: Add support for skip_verification config #2346

Merged
merged 4 commits into from
Oct 28, 2024
Merged

db/cassandra: Add support for skip_verification config #2346

merged 4 commits into from
Oct 28, 2024

Conversation

wmrmrx
Copy link
Contributor

@wmrmrx wmrmrx commented Oct 28, 2024 •
edited
Loading

Description

Adds skip_verification to Cassandra database plugin

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test -run=TestAccXXX -timeout 30m ./...
?   	github.com/hashicorp/terraform-provider-vault	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/cmd/coverage	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/cmd/generate	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/helper	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/consts	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/identity/group	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/identity/mfa	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/pki	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/sync	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/schema	[no test files]
ok  	github.com/hashicorp/terraform-provider-vault/codegen	0.007s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/internal/identity/entity	0.013s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/internal/provider	0.016s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/testutil	0.007s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/util	0.010s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/util/mountutil	0.004s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/vault	0.021s [no tests to run]
...

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@hashicorp-cla-app HashiCorp CLA App
Copy link

hashicorp-cla-app bot commented Oct 28, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hashicorp-cla-app HashiCorp CLA App
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@wmrmrx wmrmrx marked this pull request as ready for review October 28, 2024 16:14
fairclothjm
fairclothjm reviewed Oct 28, 2024
View reviewed changes
vault/resource_database_secret_backend_connection.go
Comment on lines +1050 to +1052
if v, ok := d.GetOkExists(prefix + "skip_verification"); ok {
data["skip_verification"] = v.(bool)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to add this field to the read operation as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, the resource is displaying a permanent false -> true drift for the skip_verification field.
I'm still investigating which part of the code needs to be changed to fix this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added here

@wmrmrx wmrmrx marked this pull request as draft October 28, 2024 16:36
@wmrmrx wmrmrx force-pushed the add-skip-verification branch from baffddd to 5081f17 Compare October 28, 2024 16:39
@wmrmrx wmrmrx force-pushed the add-skip-verification branch from 461b4df to d698db1 Compare October 28, 2024 16:48
@wmrmrx wmrmrx marked this pull request as ready for review October 28, 2024 16:54
@wmrmrx wmrmrx requested a review from fairclothjm October 28, 2024 16:57
@fairclothjm fairclothjm added this to the 4.5.0 milestone Oct 28, 2024
fairclothjm
fairclothjm approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wmrmrx !

@fairclothjm fairclothjm merged commit a659f2c into hashicorp:main Oct 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fairclothjm fairclothjm fairclothjm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wmrmrx @fairclothjm