Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 2107: Add missing schema fields and tests for ext_key_usage_oids #2108

Merged
merged 4 commits into from
Dec 11, 2023
Merged

fix: 2107: Add missing schema fields and tests for ext_key_usage_oids #2108

merged 4 commits into from
Dec 11, 2023

Conversation

austin-laney
Copy link
Contributor

@austin-laney austin-laney commented Dec 11, 2023 •
edited
Loading

Description

Relates OR Closes #2107

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

$ terraform-provider-vault % VAULT_TOKEN="TEST" VAULT_ADDR='http://127.0.0.1:8200' make testacc TESTARGS='-run=TestPkiSecretBackendRole'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test -run=TestPkiSecretBackendRole -timeout 30m ./...
?       github.com/hashicorp/terraform-provider-vault   [no test files]
?       github.com/hashicorp/terraform-provider-vault/cmd/coverage      [no test files]
?       github.com/hashicorp/terraform-provider-vault/cmd/generate      [no test files]
?       github.com/hashicorp/terraform-provider-vault/helper    [no test files]
?       github.com/hashicorp/terraform-provider-vault/internal/consts   [no test files]
?       github.com/hashicorp/terraform-provider-vault/internal/identity/group   [no test files]
?       github.com/hashicorp/terraform-provider-vault/internal/identity/mfa     [no test files]
?       github.com/hashicorp/terraform-provider-vault/internal/pki      [no test files]
ok      github.com/hashicorp/terraform-provider-vault/codegen   (cached) [no tests to run]
ok      github.com/hashicorp/terraform-provider-vault/internal/identity/entity  (cached) [no tests to run]
?       github.com/hashicorp/terraform-provider-vault/schema    [no test files]
ok      github.com/hashicorp/terraform-provider-vault/internal/provider (cached) [no tests to run]
ok      github.com/hashicorp/terraform-provider-vault/testutil  (cached) [no tests to run]
ok      github.com/hashicorp/terraform-provider-vault/util      (cached) [no tests to run]
ok      github.com/hashicorp/terraform-provider-vault/vault     16.497s

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@hashicorp-cla
Copy link

hashicorp-cla commented Dec 11, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@austin-laney
Copy link
Contributor Author

Configuration including new ext_key_usage_oids attribute:
Screenshot 2023-12-10 at 21 42 13

Proper configuration of role:
Screenshot 2023-12-10 at 21 43 35

Added to list of extended key usage in generated certificate:
Screenshot 2023-12-10 at 21 44 56

fairclothjm
fairclothjm reviewed Dec 11, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
fairclothjm
fairclothjm requested changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@austin-laney Thanks for the contribution! Could you please make the requested changes?

fairclothjm
fairclothjm reviewed Dec 11, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
fairclothjm
fairclothjm approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @austin-laney !

@fairclothjm fairclothjm added this to the 3.24.0 milestone Dec 11, 2023
@fairclothjm fairclothjm merged commit a11653b into hashicorp:main Dec 11, 2023
1 check passed
@fairclothjm fairclothjm mentioned this pull request Apr 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fairclothjm fairclothjm fairclothjm approved these changes

Assignees
No one assigned
Labels
documentation size/XS
Projects
None yet
Milestone
3.24.0
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Missing support for ext_key_usage_oids
3 participants
@austin-laney @hashicorp-cla @fairclothjm