Add support for lazily authenticating to Vault #2049
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously TFVP would authenticate to Vault during the provider configuration phase. Some of the negative side-effects of this approach are:
With this PR we can now do something like the following, which provisions a Vault docker instance with a dynamic host port which is used as the
vault.address
. Previously this would fail since Vault was not yet available for provisioning:Closes #1198
Closes #1907
Closes #666