Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom metadata support to namespace resource #2033

Merged
merged 9 commits into from
Oct 13, 2023
Merged

Add custom metadata support to namespace resource #2033

merged 9 commits into from
Oct 13, 2023

Conversation

vinay-gopalan
Copy link
Contributor

Description

Adds the custom_metadata argument to the vault_namespace resource.

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccNamespace'
=== RUN   TestAccNamespace
--- PASS: TestAccNamespace (9.65s)
PASS

@vinay-gopalan vinay-gopalan mentioned this pull request Sep 28, 2023
Closed
@vinay-gopalan vinay-gopalan added this to the 3.21.0 milestone Sep 28, 2023
@benashz benashz self-requested a review September 28, 2023 22:44
fairclothjm
fairclothjm approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinay-gopalan vinay-gopalan modified the milestones: 3.21.0, 3.22.0 Oct 9, 2023
benashz
benashz approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I only had a few suggestions/nits to checkout. Otherwise 👍

vault/resource_namespace.go Outdated Show resolved Hide resolved
vault/resource_namespace.go Outdated Show resolved Hide resolved
vault/resource_namespace.go Outdated
// set computed parameter to nil for vault versions <= 1.11
// prevents 'known after apply' drift in TF state since field
// would never be set otherwise
toSet[consts.FieldCustomMetadata] = nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

vault/resource_namespace.go Outdated Show resolved Hide resolved
vault/resource_namespace_test.go Outdated Show resolved Hide resolved
website/docs/r/namespace.html.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated
@@ -3,6 +3,7 @@
FEATURES:
* Add support for setting `not_before_duration` argument on `vault_ssh_secret_backend_role`: ([#2019](https://github.com/hashicorp/terraform-provider-vault/pull/2019))
* Add support for `hmac` key type and key_size to `vault_transit_secret_backend_key`: ([#2034](https://github.com/hashicorp/terraform-provider-vault/pull/2034/))
* Add support for `custom_metadata` on `vault_namespace`: ([#2033](https://github.com/hashicorp/terraform-provider-vault/pull/2033))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

vinay-gopalan and others added 3 commits October 13, 2023 15:19
@vinay-gopalan @benashz
Update vault/resource_namespace.go
9de6841 
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
@vinay-gopalan
respond to feedback
ca960ec
@vinay-gopalan
resolve merge conflicts
26e31c3
@vinay-gopalan vinay-gopalan merged commit 6bab488 into main Oct 13, 2023
@vinay-gopalan vinay-gopalan deleted the VAULT-13710/namespace-cm branch October 13, 2023 23:48
@fairclothjm fairclothjm mentioned this pull request Jan 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz approved these changes

@fairclothjm fairclothjm fairclothjm approved these changes

Assignees
No one assigned
Labels
documentation size/M
Projects
None yet
Milestone
3.22.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vinay-gopalan @fairclothjm @benashz