Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for DB Adv TTL Mgmt #2011

Merged
merged 20 commits into from
Sep 26, 2023
Merged

Add support for DB Adv TTL Mgmt #2011

merged 20 commits into from
Sep 26, 2023

Conversation

Zlaticanin
Copy link
Contributor

@Zlaticanin Zlaticanin commented Sep 12, 2023 •
edited
Loading

This PR adds two new fields rotation_schedule and rotation_window that enables users to define a schedule on which rotations should occur. If Vault version is less than 1.15, we ignore the fields.

@Zlaticanin Zlaticanin marked this pull request as ready for review September 20, 2023 16:01
@Zlaticanin Zlaticanin requested a review from a team September 20, 2023 16:01
vinay-gopalan
vinay-gopalan reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Had a couple of comments. It doesn't look like we're updating the username in the test, so not sure why it's failing 🤔 I can spend some more time later today taking a closer look at what might be going on

vault/resource_database_secret_backend_static_role.go Outdated Show resolved Hide resolved
vault/resource_database_secret_backend_static_role_test.go Show resolved Hide resolved
website/docs/r/database_secret_backend_static_role.md Outdated Show resolved Hide resolved
vault/resource_database_secret_backend_static_role.go Outdated Show resolved Hide resolved
@Zlaticanin
Copy link
Contributor Author

Looking good! Had a couple of comments. It doesn't look like we're updating the username in the test, so not sure why it's failing 🤔 I can spend some more time later today taking a closer look at what might be going on

Thank you for the review! Yeah, I am still not sure what's happening there. Looking into it as well.

@fairclothjm fairclothjm mentioned this pull request Sep 21, 2023
Merged
fairclothjm
fairclothjm approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work!

@fairclothjm fairclothjm modified the milestones: Future, 3.21.0 Sep 26, 2023
vinay-gopalan
vinay-gopalan approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for working on this 🙏🏼 Had a nit around being explicit about seconds, but good to go otherwise

vault/resource_database_secret_backend_static_role.go Outdated Show resolved Hide resolved
website/docs/r/database_secret_backend_static_role.md Outdated Show resolved Hide resolved
@Zlaticanin Zlaticanin merged commit 2653605 into main Sep 26, 2023
@Zlaticanin Zlaticanin deleted the VAULT-18523/adv-ttl-mgmt-tfvp-support branch September 26, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

@fairclothjm fairclothjm fairclothjm approved these changes

Assignees
No one assigned
Labels
documentation size/XL
Projects
None yet
Milestone
3.21.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Zlaticanin @fairclothjm @vinay-gopalan