Ensure that the auth_login honours the provider's namespace #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at the test failures now. |
benashz
force-pushed
the
VAULT-15937/ensure-auth-login-honours-the-provider-namespace
branch
from
b827505 to
00313a1
Compare
Previously, when any auth_login was configured with provider.namespace, the login would not be done in the correct namespace. This was a big problem for HCP Vault users, since the default namespace for on an HCP Vault cluster is admin.
benashz
force-pushed
the
VAULT-15937/ensure-auth-login-honours-the-provider-namespace
branch
from
00313a1 to
33fec86
Compare
fairclothjm
reviewed
May 1, 2023
fairclothjm
approved these changes
May 1, 2023
vinay-gopalan
approved these changes
May 1, 2023
jasonodonnell
approved these changes
May 2, 2023
benashz
deleted the
VAULT-15937/ensure-auth-login-honours-the-provider-namespace
branch
benashz
added a commit
that referenced
this pull request
May 4, 2023
Previously, when any auth_login was configured with provider.namespace, the login would not be done in the correct namespace. This was a big problem for HCP Vault users, since the default namespace for on an HCP Vault cluster is admin. * Only set the parent client's namespace once.
benashz
added a commit
that referenced
this pull request
Jun 5, 2023
…oken's (#1841) * Ensure that the auth_login honours the provider's namespace (#1830) Previously, when any auth_login was configured with provider.namespace, the login would not be done in the correct namespace. This was a big problem for HCP Vault users, since the default namespace for on an HCP Vault cluster is admin. * Only set the parent client's namespace once. * Add namespace tests for NewProviderMeta() * Log a warning if the non-root token TTL is below 5m * Add note about issues with short Token TTLs * Post review fixups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when any auth_login was configured with provider.namespace, the login would not be done in the correct namespace. This was a big problem for HCP Vault users, since the default namespace for on an HCP Vault cluster is admin.
In addition, the child token is now created in the same namespace as the parent token.
Closes #602