Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add role resource + test #1816

Merged
merged 9 commits into from
Apr 14, 2023
Merged

add role resource + test #1816

merged 9 commits into from
Apr 14, 2023

Conversation

Zlaticanin
Copy link
Contributor

@Zlaticanin Zlaticanin commented Apr 10, 2023

2/2 Second part of adding TFVP support for MongoDB Atlas secrets engine.

Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great so far! Had some initial comments; thanks for working on this! 😄

vault/resource_mongodbatlas_secret_role.go Outdated Show resolved Hide resolved
vault/resource_mongodbatlas_secret_role.go Outdated Show resolved Hide resolved
vault/resource_mongodbatlas_secret_role.go Outdated Show resolved Hide resolved
vault/resource_mongodbatlas_secret_role.go Show resolved Hide resolved
vault/resource_mongodbatlas_secret_role.go Show resolved Hide resolved
vault/resource_mongodbatlas_secret_role.go Outdated Show resolved Hide resolved
vault/resource_mongodbatlas_secret_role.go Outdated Show resolved Hide resolved
vault/resource_mongodbatlas_secret_role.go Outdated Show resolved Hide resolved
vault/resource_mongodbatlas_secret_role.go Outdated Show resolved Hide resolved
@Zlaticanin Zlaticanin marked this pull request as ready for review April 12, 2023 16:38
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Could we also include the docs in this PR?

vault/resource_mongodbatlas_secret_role.go Outdated Show resolved Hide resolved
vault/resource_mongodbatlas_secret_role_test.go Outdated Show resolved Hide resolved
vault/resource_mongodbatlas_secret_role.go Outdated Show resolved Hide resolved
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Had some comments, a few of which have been scoped under this PR. Let me know what you think!

vault/resource_mongodbatlas_secret_role.go Outdated Show resolved Hide resolved
website/docs/r/mongodbatlas_secret_backend.html.md Outdated Show resolved Hide resolved
vault/resource_mongodbatlas_secret_role.go Outdated Show resolved Hide resolved
vault/resource_mongodbatlas_secret_role.go Outdated Show resolved Hide resolved
vault/resource_mongodbatlas_secret_role.go Outdated Show resolved Hide resolved
of the form: `<mount_path>/roles/<role_name>` e.g.

```
$ terraform import vault_mongodbatlas_secret_role.example mongodbatlas/roles/example-role
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$ terraform import vault_mongodbatlas_secret_role.example mongodbatlas/roles/example-role
$ terraform import vault_mongodbatlas_secret_role.role mongodbatlas/roles/example-role

Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for working on this 🙏🏼

@Zlaticanin
Copy link
Contributor Author

@vinay-gopalan Thank you so much for the reviews and help! 🙏

@Zlaticanin Zlaticanin merged commit 55421ec into main Apr 14, 2023
@Zlaticanin Zlaticanin deleted the VAULT-13683/add-role-resource branch April 14, 2023 19:37
@vinay-gopalan vinay-gopalan added this to the 3.15.0 milestone Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants