-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add role resource + test #1816
add role resource + test #1816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great so far! Had some initial comments; thanks for working on this! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Could we also include the docs in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Had some comments, a few of which have been scoped under this PR. Let me know what you think!
of the form: `<mount_path>/roles/<role_name>` e.g. | ||
|
||
``` | ||
$ terraform import vault_mongodbatlas_secret_role.example mongodbatlas/roles/example-role |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ terraform import vault_mongodbatlas_secret_role.example mongodbatlas/roles/example-role | |
$ terraform import vault_mongodbatlas_secret_role.role mongodbatlas/roles/example-role |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for working on this 🙏🏼
@vinay-gopalan Thank you so much for the reviews and help! 🙏 |
2/2 Second part of adding TFVP support for MongoDB Atlas secrets engine.