raft autopilot updates #1705
raft autopilot updates #1705
Conversation
fairclothjm
force-pushed
the
vault-6022-raft-autopilot
branch
from
5be4f18 to
445b004
Compare
internal/consts/consts.go
Outdated
| FieldGroupName = "group_name" | ||
| FieldExternal = "external" | ||
| FieldInternal = "internal" | ||
| FieldAPIHostname = "api_hostname" |
There was a problem hiding this comment.
These have been sorted. I thought it might be ok do so since I was adding fields that were changing the indent level for all entries. However, I am beginning to doubt the value in doing this as it could make rebasing on top of this quite annoying.
There was a problem hiding this comment.
Hmm that is definitely a valid point! I'm now wondering if it's better to leave these unsorted and as they were for now, and we can decide on the benefits of sorting once we have finished updating all resources/datasources to use field constants — something we are tracking for long term sustainability of this project which will add to this list a lot. Might be worth adding all the constants and then sorting them in one go. What do you think?
fairclothjm
force-pushed
the
vault-6022-raft-autopilot
branch
from
156af32 to
b9a572c
Compare
internal/consts/consts.go
Outdated
| FieldGroupName = "group_name" | ||
| FieldExternal = "external" | ||
| FieldInternal = "internal" | ||
| FieldAPIHostname = "api_hostname" |
There was a problem hiding this comment.
Hmm that is definitely a valid point! I'm now wondering if it's better to leave these unsorted and as they were for now, and we can decide on the benefits of sorting once we have finished updating all resources/datasources to use field constants — something we are tracking for long term sustainability of this project which will add to this list a lot. Might be worth adding all the constants and then sorting them in one go. What do you think?
|
|
||
| // serializeFields is a map of fields that have complex structures that we will | ||
| // serialize for convenience instead of defining the schema explicitly | ||
| var serializeFields = map[string]string{ |
This PR adds a new field
disable_upgrade_migrationto the Raft autopilot resource. Additionally, we create a new data source for Raft autopilot state.Output from acceptance testing: