Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OIDC Provider support to TFVP #1363

Merged
merged 32 commits into from
Mar 24, 2022

Conversation

vinay-gopalan
Copy link
Contributor

This PR adds OIDC Scope and Assignment resources to TFVP.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccIdentityOIDCScope'
=== RUN   TestAccIdentityOIDCScope
--- PASS: TestAccIdentityOIDCScope (3.69s)
PASS

Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial pass, looking real good!

vault/resource_identity_oidc_assignment.go Outdated Show resolved Hide resolved
vault/resource_identity_oidc_assignment.go Show resolved Hide resolved
vault/resource_identity_oidc_assignment.go Show resolved Hide resolved
vault/resource_identity_oidc_assignment.go Outdated Show resolved Hide resolved
vault/resource_identity_oidc_assignment.go Outdated Show resolved Hide resolved
vault/resource_identity_oidc_scope.go Outdated Show resolved Hide resolved
vault/resource_identity_oidc_scope.go Show resolved Hide resolved
vault/resource_identity_oidc_scope.go Show resolved Hide resolved
vault/resource_identity_oidc_scope.go Outdated Show resolved Hide resolved
vault/resource_identity_oidc_scope_test.go Show resolved Hide resolved
@vinay-gopalan vinay-gopalan changed the title Add support for configuring OIDC Assignments and Scopes to Vault Provider Add OIDC Provider support to TFVP Mar 5, 2022
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

@vinay-gopalan vinay-gopalan added this to the vault-1.10 milestone Mar 14, 2022
@vinay-gopalan vinay-gopalan requested a review from benashz March 14, 2022 21:15
@benashz benashz modified the milestones: vault-1.10, 3.4.0 Mar 15, 2022
Copy link
Contributor

@austingebauer austingebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks great! Thanks @vinay-gopalan. Left a few minor suggestions and new additions coming in 1.10.

vault/data_identity_oidc_client_creds.go Outdated Show resolved Hide resolved
vault/data_identity_oidc_client_creds.go Outdated Show resolved Hide resolved
vault/data_identity_oidc_client_creds.go Show resolved Hide resolved
vault/resource_identity_oidc_client.go Show resolved Hide resolved
vault/resource_identity_oidc_client.go Outdated Show resolved Hide resolved
vault/resource_identity_oidc_client.go Show resolved Hide resolved
vault/resource_identity_oidc_client.go Outdated Show resolved Hide resolved
vault/resource_identity_oidc_client.go Show resolved Hide resolved
website/docs/r/identity_oidc_client.html.md Show resolved Hide resolved
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few new comments/nits. The resources are looking great!

I think the only thing left are the data sources. I will make another pass when they are ready.

vault/data_identity_oidc_client_creds.go Show resolved Hide resolved
vault/data_identity_oidc_client_creds.go Show resolved Hide resolved
vault/data_identity_oidc_openid_config.go Outdated Show resolved Hide resolved
vault/data_identity_oidc_openid_config.go Show resolved Hide resolved
vault/data_identity_oidc_openid_config.go Show resolved Hide resolved
website/docs/d/identity_oidc_client_creds.html.md Outdated Show resolved Hide resolved
website/docs/d/identity_oidc_client_creds.html.md Outdated Show resolved Hide resolved
website/docs/r/identity_oidc_assignment.html.md Outdated Show resolved Hide resolved
website/docs/r/identity_oidc_scope.html.md Outdated Show resolved Hide resolved
vault/resource_identity_oidc_scope.go Show resolved Hide resolved
@austingebauer austingebauer self-requested a review March 22, 2022 02:36
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nits/suggestions, but overall LGTM!

vault/data_identity_oidc_openid_config.go Outdated Show resolved Hide resolved
vault/data_identity_oidc_openid_config_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@austingebauer austingebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinay-gopalan vinay-gopalan requested a review from benashz March 23, 2022 22:07
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nits/suggestions then 👍

vault/resource_identity_oidc_provider.go Outdated Show resolved Hide resolved
vault/resource_identity_oidc_provider.go Outdated Show resolved Hide resolved
vault/resource_identity_oidc_provider.go Outdated Show resolved Hide resolved
vault/resource_identity_oidc_provider.go Outdated Show resolved Hide resolved
website/docs/d/identity_oidc_client_creds.html.md Outdated Show resolved Hide resolved
website/docs/r/identity_oidc_client.html.md Outdated Show resolved Hide resolved
website/docs/r/identity_oidc_client.html.md Outdated Show resolved Hide resolved
website/docs/r/identity_oidc_provider.html.md Outdated Show resolved Hide resolved
website/docs/r/identity_oidc_provider.html.md Outdated Show resolved Hide resolved
Copy link
Contributor

@austingebauer austingebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise. Thanks, @vinay-gopalan!

@vinay-gopalan vinay-gopalan merged commit 9294f6c into release/vault-next Mar 24, 2022
@vinay-gopalan vinay-gopalan deleted the resource/oidc-scope-assignments branch March 24, 2022 22:08
marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants