Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for configuring KMIP in TF Vault Provider #1339

Merged
merged 8 commits into from
Feb 10, 2022
Merged

Add support for configuring KMIP in TF Vault Provider #1339

merged 8 commits into from
Feb 10, 2022

Conversation

vinay-gopalan
Copy link
Contributor

This PR adds three new resources that allow users to configure KMIP using the TF Vault Provider:

  • vault_kmip_secret_backend
  • vault_kmip_secret_scope
  • vault_kmip_secret_role

Relates OR Closes #1152

Output from acceptance testing:

$  TF_ACC_ENTERPRISE=1 make testacc TESTARGS='-run=TestAccKMIPSecret'
=== RUN   TestAccKMIPSecretBackend_basic
--- PASS: TestAccKMIPSecretBackend_basic (6.48s)
=== RUN   TestAccKMIPSecretBackend_remount
--- PASS: TestAccKMIPSecretBackend_remount (3.19s)
=== RUN   TestAccKMIPSecretRole_basic
--- PASS: TestAccKMIPSecretRole_basic (3.19s)
=== RUN   TestAccKMIPSecretRole_remount
--- PASS: TestAccKMIPSecretRole_remount (3.20s)
=== RUN   TestAccKMIPSecretScope_remount
--- PASS: TestAccKMIPSecretScope_remount (3.20s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault     19.648s

benashz
benashz approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 💯

@vinay-gopalan vinay-gopalan merged commit daaa149 into main Feb 10, 2022
@vinay-gopalan vinay-gopalan deleted the VAULT-2204/kmip-support branch February 10, 2022 22:40
@vinay-gopalan vinay-gopalan mentioned this pull request Feb 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz approved these changes

Assignees
No one assigned
Labels
documentation size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support for kmip secret engine
2 participants
@vinay-gopalan @benashz