Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for configuring username and password fields for select DB Engines #1331

Merged
merged 13 commits into from
Feb 10, 2022
Merged

Add support for configuring username and password fields for select DB Engines #1331

merged 13 commits into from
Feb 10, 2022

Conversation

vinay-gopalan
Copy link
Contributor

@vinay-gopalan vinay-gopalan commented Feb 2, 2022 •
edited
Loading

This PR adds support for configuring the username and password fields in Vault through the Provider for all DB Engines that support those fields (all DBs except MongoDB Atlas)

Relates OR Closes #1314 #1329

Release note for CHANGELOG:

`resource/database_secret_backend_connection`: Add `username` and `password` fields to all DB engines that support them

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDatabaseSecretBackendConnection_mssql'
=== RUN   TestAccDatabaseSecretBackendConnection_mssql
--- PASS: TestAccDatabaseSecretBackendConnection_mssql (12.10s)
PASS

$ make testacc TESTARGS='-run=TestAccDatabaseSecretBackendConnection_postgresql'
=== RUN   TestAccDatabaseSecretBackendConnection_postgresql
--- PASS: TestAccDatabaseSecretBackendConnection_postgresql (12.10s)

make testacc TESTARGS='-run=TestAccDatabaseSecretBackendConnection_mysql'
=== RUN   TestAccDatabaseSecretBackendConnection_mysql
--- PASS: TestAccDatabaseSecretBackendConnection_mysql (5.52s)
PASS

@github-actions github-actions bot added the size/M label Feb 2, 2022
@github-actions github-actions bot added size/L and removed size/M labels Feb 4, 2022
@vinay-gopalan vinay-gopalan requested a review from benashz February 4, 2022 19:54
benashz
benashz approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great!

@github-actions github-actions bot added size/XL and removed size/L labels Feb 4, 2022
@vinay-gopalan vinay-gopalan requested a review from benashz February 4, 2022 22:49
benashz
benashz reviewed Feb 4, 2022
View reviewed changes
vault/resource_database_secret_backend_connection_test.go
Comment on lines -591 to -593
resource.TestCheckResourceAttr(testDefaultDatabaseSecretBackendResource, "data.%", "2"),
resource.TestCheckResourceAttr(testDefaultDatabaseSecretBackendResource, "data.username", testUsername),
resource.TestCheckResourceAttr(testDefaultDatabaseSecretBackendResource, "data.password", testPassword),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So these are unrelated to this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are to be removed since username and password are now being set on the resource config itself, though how these data fields are passed to Vault, I am slightly unclear on

@benashz benashz self-requested a review February 4, 2022 23:09
@benashz benashz mentioned this pull request Feb 10, 2022
Merged
benashz
benashz approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@vinay-gopalan vinay-gopalan merged commit 5c3e22b into main Feb 10, 2022
@vinay-gopalan vinay-gopalan deleted the VAULT-4836/db-username-password branch February 10, 2022 22:30
This was referenced Feb 10, 2022
Closed
Closed
@vinay-gopalan vinay-gopalan mentioned this pull request Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The PostgresQL resource is not able to rotate the root password due to missing username
2 participants
@vinay-gopalan @benashz