Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing read handler for Redshift DB #1325

Merged
merged 8 commits into from
Jan 31, 2022
Merged

Add missing read handler for Redshift DB #1325

merged 8 commits into from
Jan 31, 2022

Conversation

vinay-gopalan
Copy link
Contributor

@vinay-gopalan vinay-gopalan commented Jan 28, 2022 •
edited
Loading

This PR adds a missing case for reading data for the Redshift plugin. It also adds a default case for unrecognized plugins in databaseSecretBackendConnectionRead.

Relates OR Closes #0000

Release note for CHANGELOG:

`resource/database_secret_backend_connection`: Add error handling for unrecognized plugins on read

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDatabaseSecretBackendConnection_postgresql'
=== RUN   TestAccDatabaseSecretBackendConnection_postgresql
--- PASS: TestAccDatabaseSecretBackendConnection_postgresql (1.66s)
PASS

$ make testacc TESTARGS='-run=TestAccDatabaseSecretBackendConnection_redshift'
=== RUN   TestAccDatabaseSecretBackendConnection_redshift
--- PASS: TestAccDatabaseSecretBackendConnection_redshift (4.21s)
PASS

@vinay-gopalan vinay-gopalan requested a review from benashz January 28, 2022 19:08
@github-actions github-actions bot added size/S and removed size/XS labels Jan 28, 2022
@vinay-gopalan vinay-gopalan requested a review from benashz January 28, 2022 22:01
benashz
benashz approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nits/suggestions to address then +1

vault/resource_database_secret_backend_connection.go Outdated Show resolved Hide resolved
vault/resource_database_secret_backend_connection_test.go Show resolved Hide resolved
vault/resource_database_secret_backend_connection_test.go Outdated Show resolved Hide resolved
vault/resource_database_secret_backend_connection_test.go Outdated Show resolved Hide resolved
vault/resource_database_secret_backend_connection_test.go Outdated Show resolved Hide resolved
@vinay-gopalan vinay-gopalan changed the title Add error handling for unrecognized plugins on read Add missing read handler for Redshift DB Jan 31, 2022
@benashz benashz self-requested a review January 31, 2022 20:24
benashz
benashz approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinay-gopalan vinay-gopalan merged commit a238cf0 into main Jan 31, 2022
@vinay-gopalan vinay-gopalan deleted the fix/default-database-read branch January 31, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinay-gopalan @benashz