Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add allowed_policies_glob and disallowed_polices_glob to auth token role backend #1316

Merged
merged 6 commits into from
Jan 24, 2022
Merged

add allowed_policies_glob and disallowed_polices_glob to auth token role backend #1316

merged 6 commits into from
Jan 24, 2022

Conversation

umglurf
Copy link
Contributor

@umglurf umglurf commented Jan 23, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

Add support for allowed_policies_glob and disallowed_policies_glob in vault_token_auth_backend_role resource.

Output from acceptance testing:

$ TESTARGS="--run TokenAuthBackendRole" make testacc                           
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test -v --run TokenAuthBackendRole -timeout 20m ./...
?       github.com/hashicorp/terraform-provider-vault   [no test files]
?       github.com/hashicorp/terraform-provider-vault/cmd/coverage      [no test files]
?       github.com/hashicorp/terraform-provider-vault/cmd/generate      [no test files]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-vault/codegen   (cached) [no tests to run]
?       github.com/hashicorp/terraform-provider-vault/generated [no test files]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/decode    (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/encode    (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-vault/generated/resources/transform/alphabet    (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-vault/generated/resources/transform/role        (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-vault/generated/resources/transform/template    (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-vault/generated/resources/transform/transformation      (cached) [no tests to run]
?       github.com/hashicorp/terraform-provider-vault/helper    [no test files]
?       github.com/hashicorp/terraform-provider-vault/schema    [no test files]
?       github.com/hashicorp/terraform-provider-vault/testutil  [no test files]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-vault/util      (cached) [no tests to run]
=== RUN   TestAccTokenAuthBackendRoleImport
--- PASS: TestAccTokenAuthBackendRoleImport (0.79s)
=== RUN   TestAccTokenAuthBackendRole
--- PASS: TestAccTokenAuthBackendRole (0.58s)
=== RUN   TestAccTokenAuthBackendRoleUpdate
--- PASS: TestAccTokenAuthBackendRoleUpdate (2.07s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault     3.455s


...

@hashicorp-cla
Copy link

hashicorp-cla commented Jan 23, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

benashz
benashz reviewed Jan 24, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Only a few minor nits/suggestions.

vault/resource_token_auth_backend_role.go Outdated Show resolved Hide resolved
website/docs/r/token_auth_backend_role.html.md Outdated Show resolved Hide resolved
website/docs/r/token_auth_backend_role.html.md Outdated Show resolved Hide resolved
vault/resource_token_auth_backend_role.go Outdated Show resolved Hide resolved
vault/resource_token_auth_backend_role.go Outdated Show resolved Hide resolved
@benashz benashz added this to the 3.3.0 milestone Jan 24, 2022
umglurf and others added 5 commits January 24, 2022 16:48
@umglurf @benashz
Update vault/resource_token_auth_backend_role.go
2673aae 
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
@umglurf @benashz
Update website/docs/r/token_auth_backend_role.html.md
a73b536 
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
@umglurf @benashz
Update website/docs/r/token_auth_backend_role.html.md
2f5c26f 
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
@umglurf @benashz
Update vault/resource_token_auth_backend_role.go
254c83e 
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
@umglurf @benashz
Update vault/resource_token_auth_backend_role.go
7ac54c9 
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
benashz
benashz approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you for your contribution to HashiCorp!

@benashz benashz merged commit 5a9aad0 into hashicorp:main Jan 24, 2022
@umglurf umglurf deleted the token-auth-backend-glob branch January 24, 2022 15:56
benashz added a commit that referenced this pull request Jan 27, 2022
@benashz
Update changelog for #1316
bcf64b8
@benashz benashz mentioned this pull request Jan 27, 2022
Merged
benashz added a commit that referenced this pull request Jan 28, 2022
@benashz
Update changelog for #1316 (#1324)
26a0f42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz approved these changes

Assignees
No one assigned
Labels
documentation ecosystem feature-parity size/M
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@umglurf @hashicorp-cla @benashz