Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure disable_iss_validation is honored #1315

Merged
merged 2 commits into from
Jan 21, 2022
Merged

Ensure disable_iss_validation is honored #1315

merged 2 commits into from
Jan 21, 2022

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Jan 20, 2022

Previously we were using GetOk() on a boolean schema field for
disable_iss_validation which prevented the provider from provisioning
Vault's Kubernetes auth backend properly.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #1313

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-v -test.run TestAccKubernetesAuthBackendConfig'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test -v -v -test.run TestAccKubernetesAuthBackendConfig -timeout 20m ./...

ok      github.com/hashicorp/terraform-provider-vault/util      (cached) [no tests to run]
=== RUN   TestAccKubernetesAuthBackendConfigDataSource_basic
--- PASS: TestAccKubernetesAuthBackendConfigDataSource_basic (3.29s)
=== RUN   TestAccKubernetesAuthBackendConfigDataSource_full
--- PASS: TestAccKubernetesAuthBackendConfigDataSource_full (3.01s)
=== RUN   TestAccKubernetesAuthBackendConfig_import
--- PASS: TestAccKubernetesAuthBackendConfig_import (3.94s)
=== RUN   TestAccKubernetesAuthBackendConfig_basic
--- PASS: TestAccKubernetesAuthBackendConfig_basic (1.71s)
=== RUN   TestAccKubernetesAuthBackendConfig_update
--- PASS: TestAccKubernetesAuthBackendConfig_update (3.00s)
=== RUN   TestAccKubernetesAuthBackendConfig_full
--- PASS: TestAccKubernetesAuthBackendConfig_full (1.71s)
=== RUN   TestAccKubernetesAuthBackendConfig_fullUpdate
--- PASS: TestAccKubernetesAuthBackendConfig_fullUpdate (4.30s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault     21.770s
...

@benashz
Ensure disable_iss_validation is honored
8f8206b 
Previously we were using `GetOk()` on a boolean schema field for
disable_iss_validation which prevented the provider from provisioning
Vault's Kubernetes auth backend properly.
@benashz benashz modified the milestones: 3.2.0, 3.3.0 Jan 20, 2022
@benashz benashz requested a review from vinay-gopalan January 20, 2022 16:18
@benashz benashz merged commit 775302c into main Jan 21, 2022
@benashz benashz deleted the VAULT-4834/ensure-iss-validation-can-be-disabled branch January 21, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
3.3.0
2 participants
@benashz @vinay-gopalan