Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include support to delete key metadata for kv-v2 generic secrets #1254

Merged
merged 12 commits into from
Dec 17, 2021
Merged

Include support to delete key metadata for kv-v2 generic secrets #1254

merged 12 commits into from
Dec 17, 2021

Conversation

vinay-gopalan
Copy link
Contributor

@vinay-gopalan vinay-gopalan commented Dec 8, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes
#760
https://hashicorp.atlassian.net/browse/VAULT-4351

Release note for CHANGELOG:

resource/generic_secret: Add support for deleting key metadata and all version data for a secret

Output from acceptance testing:

$ make testacc TESTARGS='-v -run TestResourceGenericSecret'
=== RUN   TestResourceGenericSecret
--- PASS: TestResourceGenericSecret (3.29s)
=== RUN   TestResourceGenericSecret_deleted
--- PASS: TestResourceGenericSecret_deleted (3.01s)
=== RUN   TestResourceGenericSecret_deleteAllVersions
--- PASS: TestResourceGenericSecret_deleteAllVersions (2.95s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault     9.412s

@vinay-gopalan vinay-gopalan requested a review from benashz December 8, 2021 22:13
@vinay-gopalan vinay-gopalan added this to the 3.1.0 milestone Dec 8, 2021
benashz
benashz requested changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions/requests.

vault/resource_generic_secret_test.go Outdated Show resolved Hide resolved
vault/resource_generic_secret_test.go Outdated Show resolved Hide resolved
vault/resource_generic_secret_test.go Outdated Show resolved Hide resolved
website/docs/r/generic_secret.html.md Show resolved Hide resolved
@benashz benashz mentioned this pull request Dec 14, 2021
Closed
@github-actions github-actions bot added size/L and removed size/M labels Dec 16, 2021
benashz
benashz requested changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! A few suggestions.

vault/resource_generic_secret.go Show resolved Hide resolved
vault/resource_generic_secret_test.go Outdated Show resolved Hide resolved
vault/resource_generic_secret_test.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
benashz
benashz reviewed Dec 17, 2021
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last suggestion :)

vault/resource_generic_secret_test.go Outdated Show resolved Hide resolved
benashz
benashz approved these changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinay-gopalan vinay-gopalan merged commit 66bba37 into main Dec 17, 2021
@vinay-gopalan vinay-gopalan deleted the feature/kvv2-delete-all branch December 17, 2021 22:27
@rosezafar rosezafar mentioned this pull request Jan 10, 2022
Closed
@g-psantos g-psantos mentioned this pull request Jan 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz approved these changes

Assignees
No one assigned
Labels
documentation feature-parity size/L
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vinay-gopalan @benashz