Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update changelog and add tests for the generic_secret data source. #1216

Merged
merged 5 commits into from
Nov 5, 2021
Merged

Update changelog and add tests for the generic_secret data source. #1216

merged 5 commits into from
Nov 5, 2021

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Nov 5, 2021

This PR adds test for the generic_secret's lease_start_time field. Its value is now stored in UTC.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #770

Release note for CHANGELOG:

Output from acceptance testing:

make dev testacc TESTARGS='-v -test.run TestDataSource.*Secret' TF_LOG=error
==> Checking that code complies with gofmt requirements...
go build -o terraform-provider-vault
mv terraform-provider-vault ~/.terraform.d/plugins/
TF_ACC=1 go test $(go list ./...) -v -v -test.run TestDataSource.*Secret -timeout 20m

[...]

=== RUN   TestDataSourceGenericSecret
--- PASS: TestDataSourceGenericSecret (2.21s)
=== RUN   TestDataSourceGenericSecret_v2
--- PASS: TestDataSourceGenericSecret_v2 (4.65s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault     7.504s
...

tomhjp
tomhjp approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just nits

website/docs/d/generic_secret.html.md Outdated Show resolved Hide resolved
vault/data_source_generic_secret_test.go Outdated Show resolved Hide resolved
benashz and others added 2 commits November 5, 2021 11:40
@benashz @tomhjp
Update website/docs/d/generic_secret.html.md
12d6198 
Co-authored-by: Tom Proctor <tomhjp@users.noreply.github.com>
@benashz
Fix formatting test errors
85d95f3
@benashz benashz merged commit b46583e into main Nov 5, 2021
@benashz benashz deleted the add-tests-changelog-for-770 branch November 5, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhjp tomhjp tomhjp approved these changes

@tvoran tvoran Awaiting requested review from tvoran

@vinay-gopalan vinay-gopalan Awaiting requested review from vinay-gopalan

Assignees
No one assigned
Labels
documentation size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benashz @tomhjp