Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] resource/vault_identity_group external member_entity_ids & member_group_ids #1134

Merged
merged 1 commit into from
Sep 4, 2021
Merged

[FIX] resource/vault_identity_group external member_entity_ids & member_group_ids #1134

merged 1 commit into from
Sep 4, 2021

Conversation

gavinelder
Copy link
Contributor

@gavinelder gavinelder commented Aug 4, 2021 •
edited
Loading

Summary

Follow up from Linked PRS #1061 & #1054 to ensure member_entity_ids & member_group_ids are only managed on internal groups

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #1133

Release note for CHANGELOG:

resource/vault_identity_group: Fix bug where member_entity_ids &  member_group_ids  were attempted to be managed on external identity groups.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@hashicorp-cla
Copy link

hashicorp-cla commented Aug 4, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gavinelder gavinelder changed the title Don't attempt to manage member_entity_ids or member_group_ids for ext… [FIX] resource/vault_identity_group external member_entity_ids & member_group_ids Aug 16, 2021
@tvoran tvoran merged commit f350bc4 into hashicorp:master Sep 4, 2021
@gavinelder gavinelder deleted the vault_identity_group branch October 1, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvoran tvoran tvoran approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vault_identity_group updates fail on policy change for external groups.
3 participants
@gavinelder @hashicorp-cla @tvoran